pandas updates and updated error catching#5
Open
dschneiderch wants to merge 6 commits intojaredwo:nrcs_py3_fixesfrom
Open
pandas updates and updated error catching#5dschneiderch wants to merge 6 commits intojaredwo:nrcs_py3_fixesfrom
dschneiderch wants to merge 6 commits intojaredwo:nrcs_py3_fixesfrom
Conversation
Author
|
The last commit fixes the example in teh README. Instead of catching an OSERROR I changed it to a FileNotFoundError - based on the string your were searching for I think thats what you were doing. if the file didn't exist catch the error and download it. I don't know if any other errors are likely there besides filenotfound closes #2 |
dschneiderch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jared,
I guess you aren't really working on this anymore but it's a shame because as you know most hydrologists don't have the skills to create this sorely needed tool!
a couple fixes for nrcs downloader that are mostly updates to pandas
at least the suds error is resolved in v1.4.x so closes #3
this resolves the issues I was having downloading station metadata.
Running the example in the README isn't working due to a missing ghcn files and I couldn't download the data from nrcs with read_obs() (it was returning an empty df, no error)